search

ls1intum / Apollon_standalone

Standalone version of Apollon Editor
MIT License
11 stars 2 forks source link

Resolve issues with the conversion service exiting unexpectedly #55

Closed matthiaslehnertum closed 1 year ago

matthiaslehnertum commented 1 year ago

This PR attempts to solve the issues with the conversion service exiting with an error code when attempting to export a Apollon diagram as SVG.

The issue seems to be the initialization of the package JSDOM. The package used for initilization previously (jsdom-global) is no longer maintained and has last been updated in 2017. The replacement package "global-jsdom" seems to resolve this issue.

I additionally updated the node version of the Docker image as the global-jsdom package expects a minimum version of node 18.

loreanvictor commented 1 year ago

I couldn't replicate the issue, neither locally nor on GitHub codespaces. However the proposed version also works fine and jsdom-global have not been updated in 6 years while global-jsdom is actively maintained, so regardless of the issue I think it is a good idea to switch.