empty team exercise submissions cannot be assessed

csarpkaya commented 4 years ago

Describe the bug

When a team submits an empty solution to an exercise, it's not possible to assess it.

To Reproduce

Go to Tutor Course Dashboard>TE Exercise Teams > Team Overview
Click on "Start new assessment" on an empty submission
Scroll down to "Add new feedback", add a feedback with 0 points.
Click on "Submit"
See error

Expected behavior

You should be able to assess the empty exercise with 0 points.

Screenshots

Additional context

You are able to click "Save" and save the assessment to continue later, however submitting doesn't work.

Output in Web Console

ERROR TypeError: Cannot read property 'elements' of undefined
    at CC.onSubmitAssessment (modeling-assessment-editor.component.ts:265)
    at modeling-assessment-editor.component.html:1
    at Zs (core.js:21806)
    at r (core.js:21848)
    at d.o [as _next] (core.js:37171)
    at d.__tryOrUnsub (Subscriber.js:183)
    at d.next (Subscriber.js:122)
    at s._next (Subscriber.js:72)
    at s.next (Subscriber.js:49)
    at Fu.next (Subject.js:39)
    at Fu.emit (core.js:37079)
    at assessment-layout.component.html:1
    at Zs (core.js:21806)
    at r (core.js:21848)
    at d.o [as _next] (core.js:37171)
    at d.__tryOrUnsub (Subscriber.js:183)
    at d.next (Subscriber.js:122)
    at s._next (Subscriber.js:72)
    at s.next (Subscriber.js:49)
    at Fu.next (Subject.js:39)
    at Fu.emit (core.js:37079)
    at assessment-header.component.html:24
    at Zs (core.js:21806)
    at r (core.js:21848)
    at HTMLButtonElement. (platform-browser.js:976)
    at HTMLButtonElement.o (helpers.js:71)
    at t.invokeTask (zone.js:421)
    at Object.onInvokeTask (core.js:41632)
    at t.invokeTask (zone.js:420)
    at n.runTask (zone.js:188)
    at n.invokeTask [as invoke] (zone.js:503)
    at m (zone.js:1671)
    at HTMLButtonElement.p (zone.js:1697)

MaisiKoleni commented 4 years ago

Possible duplicate of #1600.

julian-christl commented 4 years ago

It actually is. However my findings are actually not related to this specific issue. I misread this issue. Will create a new Issue for my case tomorrow. Thanks for mentioning.

boz1 commented 4 years ago

I've got the exact same error for an empty exercise submission in T04E02 (Model) https://github.com/ls1intum/Artemis/issues/1670#issuecomment-650733979 And this is the error output for an empty submission in T04E03 (Text)

julian-christl commented 4 years ago

@boz1 I think you are searching for #1774

ls1intum / Artemis