search

ls1intum / Artemis

Artemis - Interactive Learning with Automated Feedback
https://docs.artemis.cit.tum.de
MIT License
502 stars 289 forks source link

Manual assessed exercises are accounted too early #4269

Open JohannesStoehr opened 2 years ago

JohannesStoehr commented 2 years ago

Describe the bug

We currently have manually assessed exercises where the duedate is over but the assessment duedate is not. The achieved score of the students is already updated and includes the points from the unassessed exercises, but the overall achievable points are not updated.

To Reproduce

  1. Create a manually assessed programming exercise
  2. Participate as a student and pass some or all tests
  3. Wait for the deadline but still be before the assessment due date
  4. See error

Expected behavior

The points should not yet be included in the score, since they can still change through the manual assessment. An alternative would be to include the exercises in the overall score as well, but the first option appears to be more suiting for me.

Screenshots

Screen_Shot_2021-11-08_at_10 10 59_AM

What browsers are you seeing the problem on?

Chrome, Safari, Microsoft Edge, Firefox

Additional context

No response

Relevant log output

No response

krusche commented 2 years ago

we probably need to filter those results in the initial for-dashboard REST call. I guess this was not maintained correctly, when the manual assessment was introduced to programming exercises. Can you check how this is done for modeling, text and file upload exercises? A similar filter is needed if the manual assessment for programming exercises is active and the assessment due date was set but not yet passed