search

ls1intum / Artemis

Artemis - Interactive Learning with Automated Feedback
https://docs.artemis.cit.tum.de
MIT License
506 stars 292 forks source link

Dark Mode: White font on (yellow | light green) hard to read #5045

Closed Shirkanesi closed 2 years ago

Shirkanesi commented 2 years ago

Describe the bug

When using the dark-mode the white text on (yellow | light green)background is quite hard to read. (see screenshots below)

To Reproduce

Navigate through the UI and look for (yellow | light green) elements (e.g. buttons, progress-bars, file-names in the editor)

Expected behavior

The colors should be adjusted so text is still readable.

Screenshots

In the assessment-dashboard: grafik

In the code-editor: grafik

In the code-editor for assessment: grafik

What browsers are you seeing the problem on?

Other (specify in "Additional context")

Additional context

No response

Relevant log output

No response

bassner commented 2 years ago

That looks rather like an opinion than a bug.

The colors are mostly taken from https://bootswatch.com/darkly/, a widely accepted dark theme for Bootstrap. To me, the example you showed look fine to be honest.

Unless we get more similar feedback, I'd keep the colors for now.

Shirkanesi commented 2 years ago

That looks rather like an opinion than a bug.

Of course. Colors are always opinions.

The colors are mostly taken from https://bootswatch.com/darkly/, a widely accepted dark theme for Bootstrap. To me, the example you showed look fine to be honest.

I totaly agree. The text on their example is quite readable. It might be a combination of the font(-size and -weight) used in Artemis and my screen. I've looked at it on a completely different screen, there it looked good.

I think we should totaly wait whether more people have problems with it on their system or if this is just a "me-problem".

ge65cer commented 2 years ago

Closed in favor of #5091