ls1intum / Artemis

Artemis - Interactive Learning with Automated Feedback
https://docs.artemis.cit.tum.de
MIT License
456 stars 274 forks source link

Thin Fonts depending on installed system fonts #5091

Open b-fein opened 2 years ago

b-fein commented 2 years ago

Describe the bug

The low contrast for the breadcrumbs with very thin blue font on dark grey background results in bad legibility.

See also my comment below for more context about thin fonts.

To Reproduce

  1. Open some page within Artemis in dark mode and look at the breadcrumbs at the top.

Expected behavior

Breadcrumbs are easily readable in dark mode.

Screenshots

Screenshot 2022-05-15 at 07-17-08 Programming Exercises

What browsers are you seeing the problem on?

Firefox

Additional context

No response

Relevant log output

No response

bassner commented 2 years ago

Hmm. It doesn't look that "thin" on my screen and is pretty readable, though ... 🤔

Could be related to https://github.com/ls1intum/Artemis/issues/5045 where the font looks similarly thin

b-fein commented 2 years ago

I think this is an issue due to font selection if you have got multiple subfamilies (Regular, Thin, …) of the Noto Sans font that is used as default sans-serif on many Linux systems. Those systems also don’t have got Arial/Helvetica (is there even some explicit sans-serif font specified in the CSS of Artemis?) most of the time.

The problem statement text of an exercise and the items in the code editor file browser as in the linked issue are also in a different weight: Noto Sans Light. I sometimes wondered why there are so many different font weights used in Artemis, but maybe the difference in weights is not that different/does not happen depending on the fonts you have got installed.

bassner commented 2 years ago

Seems like the solution would rather be to ship and force the same font on all systems rather than changing the font weight to make the web app appear consistent across all platforms

ge65cer commented 2 years ago

+1 on shipping the font with Artemis