ls1intum / Artemis

Artemis - Interactive Learning with Automated Feedback
https://docs.artemis.cit.tum.de
MIT License
457 stars 275 forks source link

Download opens empty page in new window #6942

Open MariusAlbrecht opened 12 months ago

MariusAlbrecht commented 12 months ago

Describe the bug

Clicking the download button a) downloads the appropriate file but also b) opens an empty page (about:blank) in a new window (and focuses on that)

This can somewhat be avoided by some browser tweaks but still leaves one with lots of useless and unnecessary tabs

  1. stopping the browser from opening links in new windows and opening the links in new tabs instead (browser.link.open_newwindow = 3 in firefox eg)
  2. stopping the browser from focusing on those diverted tabs (browser.tabs.loadDivertedInBackground = true in firefox eg)

To Reproduce

  1. Go to a specific Lecture
  2. Click on "Download" for any of the materials
  3. See error

Expected behavior

Stay in the original tab and dont open any new pages, let alone focus on them

Screenshots

No response

Which version of Artemis are you seeing the problem on?

6.3.4

What browsers are you seeing the problem on?

Firefox

Additional context

ff 115.0.2

Relevant log output

No response

krusche commented 11 months ago

I think the behavior depends on the browser. In chrome and safari, I see the PDF directly in the browser