ls1intum / Artemis

Artemis - Interactive Learning with Automated Feedback
https://docs.artemis.cit.tum.de
MIT License
456 stars 275 forks source link

File Upload for Tutors/Instructors to provide individual feedback (File Upload Exercises) #8792

Open kerstinandree opened 2 weeks ago

kerstinandree commented 2 weeks ago

Is your feature request related to a problem?

When students upload a file, e.g., a pdf, via the Upload File Exercise to submit their homework, I can't provide valuable feedback that helps the students in improving their skills. This is especially frustrating for modeling exercises for which students use a modeling language not supported by Artemis. I can only provide feedback via the drag and drop criteria I defined but this feedback is not directly attached to a modeling element. As an instructor, I consider this way of giving feedback as not appropriate because students have to know in detail which modeling elements are wrong, which relation I mean in the feedback, and so on. Even when I am giving feedback by using a pdf tool to write my comments directly into the pdf I am not able to upload my feedback file.

Describe the solution you'd like

I would like to have the chance to upload a feedback file for a file upload assignment. Being able to upload a file also means that I am independent of the modeling languages supported by Artemis but I still can give valuable feedback, so that students understand what exactly they did wrong. Alternatively, a pdf editor integrated in Artemis would also be an option so that I can drag and drop the feedback to the pdf.

Describe alternatives you've considered

No response

Additional context

No response

b-fein commented 2 weeks ago

We (@uni-passau-artemis) also thought about something like this since Moodle supports this and would ease the migration for some exercises, but sadly did not and currently do not have the capacity to implement this.

At the time we thought about a fairly generic model that allows attaching feedback files to the manual feedback for any exercise type:

domain_model

This would then also allow the tutor to upload for example a screenshot of a visual bug encountered in case of programming exercises where students implement a UI.

Note: the data model in principle would allow for multiple attachments to make it more flexible.


Very rough mock-ups from quite some time ago how that could look like as student and instructor:

Screenshot 2023-05-04 at 16-20-14 File Upload Exercises Screenshot 2023-05-04 at 16-21-00 File Upload Exercises


We had the idea to implement this in two building blocks:

  1. Having the generic option to upload attachment files for feedback. I.e. the tutor downloads the PDF, annotates additional stuff in the document directly, and uploads it back to Artemis.
  2. Allowing the PDF annotation directly in Artemis (like supported by Moodle).
    • I.e. open the submission in a new tab with the in-browser-PDF-viewer, make annotations there, and automatically save it as feedback attachment.
    • In principle, the JavaScript-PDF-viewers in all browsers should support something like this.
    • Open question: PDF allows embedding scripts. E.g. could a malicious PDF uploaded by a student be used to extract the token used to authenticate against Artemis from the tutor’s session?


Together with other issues related to the assessment (e.g. #5140, #4870), this could maybe be combined into a possible thesis related to improvements to the assessment process (i.e. one of the important core features) in Artemis?