search

ls1intum / Artemis

Artemis - Interactive Learning with Automated Feedback
https://docs.artemis.cit.tum.de
MIT License
452 stars 275 forks source link

`Exam mode`: Missing instructor validation on csv user import #8879

Open florian-glombik opened 4 days ago

florian-glombik commented 4 days ago

Describe the bug

When importing users with a CSV, where user a is an instructor the UI will show that all users have been imported, but the instructor will not be registered for the exam (which is the expected behavior - instructors are not registered for exams - but it should be displayed in the UI that the user was not imported)

To Reproduce

  1. Create an exam
  2. Click on "Students" and then "Import users"
  3. Upload a CSV file with the login of an instructor of the course and import it

Example CSV where instructorUserLogin is an instructor in the course: students-import-2023-09-25 -instructor-user1.csv

We also previously named the button Import Students - I think this was a better button name to prevent confusion.

Expected behavior

The instructor user shall not be displayed as imported.

Screenshots

exam-student-csv-import-missing-validation

Which version of Artemis are you seeing the problem on?

7.3.1

What browsers are you seeing the problem on?

Chrome

florian-glombik commented 4 days ago

A fix to this might also resolve Exam mode: Importing a user with incorrespond registration number and login account failed without error report to user

EDIT: I think that the underlying issue was hat the same reason, we just didn't boil it down to the instructor role there.