search

ls1intum / Artemis

Artemis - Interactive Learning with Automated Feedback
https://docs.artemis.cit.tum.de
MIT License
452 stars 275 forks source link

`Exam mode`: Fix displaying exam grade with and without bonus #8912

Closed SimonEntholzer closed 1 day ago

SimonEntholzer commented 2 days ago

Checklist

General

Client

Motivation and Context

Students should be able to see their final grade when viewing the exam results.

Description

Fixes https://github.com/ls1intum/Artemis/issues/8909

Steps for Testing

Fixes https://github.com/ls1intum/Artemis/issues/8909

Testserver States

[!NOTE] These badges show the state of the test servers. Green = Currently available, Red = Currently locked Click on the badges to get to the test servers.

Review Progress

Performance Review

Code Review

Test Coverage

Screenshots

Before: image

With no grade bonus: image

With grade bonus enabled: image

Summary by CodeRabbit

coderabbitai[bot] commented 2 days ago

Walkthrough

The recent changes in the exam-result-overview.component.html add conditional rendering to show grades before and after applying a bonus. If a finalGrade exists in studentExamWithGrade.studentResult.gradeWithBonus, the final grade is displayed, addressing the issue where the final grade was previously not shown in the exam report.

Changes

File(s) Change Summary
.../exam-result-overview.component.html Added conditional logic to display final grade information if finalGrade is present.

Sequence Diagram(s)

Assessment against linked issues

Objective Addressed Explanation
Display the final grade in the exam report if it exists (#8909) ✅
Recent review details **Configuration used: .coderabbit.yaml** **Review profile: ASSERTIVE**
Commits Files that changed from the base of the PR and between 41682036320a62289545cb9327108e95f4dd7b1f and d5d5567bc068fa313e4f1705ffc34a1e196e318f.
Files selected for processing (1) * src/main/webapp/app/exam/participate/summary/result-overview/exam-result-overview.component.html (1 hunks)
Additional context used
Path-based instructions (1)
src/main/webapp/app/exam/participate/summary/result-overview/exam-result-overview.component.html (1) Pattern `src/main/webapp/**/*.html`: @if and @for are new and valid Angular syntax replacing *ngIf and *ngFor. They should always be used over the old style.
Additional comments not posted (3)
src/main/webapp/app/exam/participate/summary/result-overview/exam-result-overview.component.html (3)
Line range hint `1-150`: **Usage of new Angular syntax is consistent and correct.** The file consistently uses the new `@if` and `@for` syntaxes, which is in line with the latest Angular recommendations and the additional instructions provided. [APROVED] --- Line range hint `1-150`: **HTML structure and semantics are well-implemented.** The use of semantic HTML elements and accessible attributes (like `scope` for table headers) enhances the accessibility and readability of the content. --- Line range hint `1-150`: **Translations and dynamic data bindings are correctly implemented.** The extensive use of translation keys and dynamic data bindings ensures that the content is localized and responsive to the data model changes.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.