ls1intum / Artemis

Artemis - Interactive Learning with Automated Feedback
https://docs.artemis.cit.tum.de
MIT License
502 stars 289 forks source link

`Exam mode`: The PDF summary → When the diagram is big, the next question overlaps it. #8930

Open Santia-go opened 3 months ago

Santia-go commented 3 months ago

Describe the bug

The PDF summary→ When the diagram is big, the next question overlaps it.

To Reproduce

  1. Solve an exam with modeling exercises
  2. Create a big diagram
  3. Download the summary and verify that the next question overlaps it.

Expected behavior

The size of the diagram should be scaled to the size of the page or the next question should not overlap the diagram

Screenshots

image

Which version of Artemis are you seeing the problem on?

7.3.0

What browsers are you seeing the problem on?

Chrome

Additional context

No response

Relevant log output

No response

az108 commented 3 months ago

What i was able to achieve was, increasing the modelling sumbission container so that it covers the whole exercise. Now it reaches out till the last page as seen in the images below. What I could not do was increase the card body accordingly and for some reason there is this big whitespace when the modelling card starts which i am unable to debug. I have tried emulating the print functionality and I think the root cause of issues is the fact that the sumbission container does not fit in the card body. It would be ideal to fix this somehow, help is needed 🥲 1:

image

2:

image

3:

image
az108 commented 3 months ago

Update: I could aswell fix that the sumbission container adjusts its size according to the sumbission. The only problem left is the weird page break or whitespace under the card header. If the white space is gone and the modelling sumbission is displayed from the card header then everything should now fit in the sumbission container. 1.

image

2.

image

3.

image
az108 commented 3 months ago

The whitespace should not be there, without it the whole content will fit into the box now after the changes i have merged for the scalings of the parent containers. The height and size of the parent containers were related to this and are fixed now and of appropriate size. This is only a edge case related to the content which gets moved by random whitespace appearing. The whitespace does not appear for vertically normal modelling diagrams and the summary gets displayed correctly. Emulating a print view also did not help much as fixing the error there did not fix the issue in the pdf preview.