ls1intum / Artemis

Artemis - Interactive Learning with Automated Feedback
https://docs.artemis.cit.tum.de
MIT License
505 stars 292 forks source link

Incorrect handling of time extension after individual exam end #9390

Open MaximilianAnzinger opened 1 month ago

MaximilianAnzinger commented 1 month ago

Describe the bug

When instructors extend the time of a student after the exam has officially ended, the student can again access the exam, but is unable to push code.

To Reproduce

  1. Let exam end
  2. Extend working time of the student
  3. Try to push code again -> not allowed

Expected behavior

The student should be allowed to submit code

Screenshots

No response

Which version of Artemis are you seeing the problem on?

7.5.4

What browsers are you seeing the problem on?

Chrome

Additional context

No response

Relevant log output

No response

krusche commented 1 month ago

The issue might be that the corresponding student participation was marked as locked when the individual exam ends (even when the timer runs out). I think there is a scheduled task for that.

The student exam time extension feature (either individual or the complete exam) would need to go through all related student participations and mark them as unlocked, if and only if:

  1. There are no submission policies in the respective programming exercise
  2. There is a submission policy, but its limit was not reached yet