ls1intum / Artemis

Artemis - Interactive Learning with Automated Feedback
https://docs.artemis.cit.tum.de
MIT License
514 stars 294 forks source link

`Athena`: Unable to get further AI feedback after first execution #9550

Open flodt opened 1 month ago

flodt commented 1 month ago

Describe the bug

When a text exercise is submitted, AI feedback can initially be requested. After this was done, and the exercise has been modified (e.g. by the student incorporating the feedback) and submitted again, no further AI feedback can be requested. The resulting error message is This submission already has an existing AI result. Please submit again before requesting further feedback..

To Reproduce

  1. Go to any text exercise
  2. Submit a solution for the first time
  3. Request AI feedback
  4. Open the editor again and change the content
  5. Submit another time
  6. Request AI feedback again

Expected behavior

The existing feedback is cleared and new AI feedback is generated for the new/changed/most recent submission.

Screenshots

image

Which version of Artemis are you seeing the problem on?

7.6.1

What browsers are you seeing the problem on?

Firefox

Additional context

No response

Relevant log output

No response

maximiliansoelch commented 1 month ago

This apparently also happened for Modeling Exercises.

matilde-t commented 1 month ago

At least for Modeling Exercises, now after submitting the notification says that I submitted and an AI feedback is ready, even if there is no new feedback (and I cannot request it manually like this issue shows)

Seba2312 commented 1 month ago

The due date for the exercise is on Monday. Would it be possible to change the logic that checks if AI assistance can be used? Currently, the system checks if the IDs match, but it's not working. I suggest implementing a simple time check instead. For example, after 20 minutes have passed, AI assistance would be enabled, allowing us to receive feedback before the deadline. This would serve as an interim solution while a proper fix is being developed.

Specifically, in the file request-feedback-button.component.ts, could the function hasAthenaResultForLatestSubmission be adjusted to perform a time check instead of: return ( this.participation.submissions?.last()?.id === this.participation.results?.filter((result) => result.assessmentType == AssessmentType.AUTOMATIC_ATHENA).first()?.submission?.id );

EneaGore commented 1 month ago

This issue will be fixed (practically at least) for text exercises by https://github.com/ls1intum/Artemis/pull/9395

Seba2312 commented 1 month ago

I tested it today and the issue continues to persist, was the fix implemented?