search

ls1intum / Artemis

Artemis - Interactive Learning with Automated Feedback
https://docs.artemis.cit.tum.de
MIT License
513 stars 294 forks source link

Performance: Scores page creates many API requests to the ide-settings endpoint #9559

Open b-fein opened 1 month ago

b-fein commented 1 month ago

Describe the bug

The scores page for programming exercises contains the </> Code button for every student. Every one of those buttons makes a request to the /api/ide-settings endpoint.

To Reproduce

  1. Open the Network tab of the browser dev console.
  2. Go to the Scores page for the exercise.
  3. Observe the many REST calls to the API.

Expected behavior

Only requested once by the client as part of the user information or similar and cached.

Screenshots

No response

Which version of Artemis are you seeing the problem on?

7.5.6

What browsers are you seeing the problem on?

Firefox

Additional context

No response

Relevant log output

No response

b-fein commented 1 month ago

Related PR #9201

/cc @janthoXO

krusche commented 1 month ago

Fixed in d3ddb926a449c0c4f7bc6792121fe5d0306a45ed

janthoXO commented 1 month ago

https://github.com/ls1intum/Artemis/commit/d3ddb926a449c0c4f7bc6792121fe5d0306a45ed was only a temporary fix. i will provide a fix in an upcoming PR