ls1intum / Athena

A system to support (semi-)automated assessment of exercises, built on ls1intum/Athena
https://ls1intum.github.io/Athena/
6 stars 1 forks source link

Use different decorators and schemas for graded and non-graded feedback suggestions. #319

Closed dmytropolityka closed 3 months ago

dmytropolityka commented 4 months ago

Is your feature request related to a problem?

We currently use a decorator suggest_feedback for both graded and non-graded feedback suggestions. It might make sense to use different decorators.

Also, Athena reuses the schema for graded feedback suggestions to generate non-graded feedback suggestions. The schema contains fields like credits or grading instructions. Do we still need these fields?

Describe the solution you'd like

Separate the logic behind the decorators. Also, the modules are scanned automatically to detect the features they support. Decide whether to keep the existing schema or develop a new one.

Describe the alternatives you've considered

No response

Additional context

No response

FelixTJDietrich commented 4 months ago

I think this can be done in combination with #318.

FelixTJDietrich commented 3 months ago

This might be obsolete for now, we have to discuss with @maximiliansoelch

FelixTJDietrich commented 3 months ago

We will no longer do this