ls1intum / Orion

Plugin integrating Artemis programming exercises into IntelliJ
https://plugins.jetbrains.com/plugin/13217-orion--artemis-programming-exercise-integration/
MIT License
32 stars 8 forks source link

`Bugfix/Enhancement` Fixed version control related bugs #107

Closed Kroko-fant closed 7 months ago

Kroko-fant commented 8 months ago

Motivation and Context

Artemis has changed DTOs from URL to URI which broke some plugin code that depends on the repository URLs. https://github.com/ls1intum/Artemis/pull/7838

Furthermore Artemis has changed the version-control system away from Bitbucket. Orion however still referenced the TUM bitbucket

This pr fixes: https://github.com/ls1intum/Orion/issues/104 https://github.com/ls1intum/Orion/issues/105 https://github.com/ls1intum/Orion/issues/106

Description

Steps for Testing

  1. Install the release as described in the readme
  2. Open an exercise in Orion 2.1. As a student 2.2. As a tutor 2.3. As an instructor -> verify that the cloning process does not throw errors as described in the linked issues
  3. Open the settings UI and verify that the new field is present
  4. ...

Review Progress

Code Review

Screenshots

grafik Updated Settings UI

Kroko-fant commented 8 months ago

This may only be a partial fix for #104. The error message is still

Id of the opened submission and the loaded Artemis page do not match, loading of feedback aborted. Make sure to open the correct submission in Orion.

This may only be a partial fix for #104. The error message is still

Id of the opened submission and the loaded Artemis page do not match, loading of feedback aborted. Make sure to open the correct submission in Orion.

I tried replicating this issue and couldn't get it replicated. Does setting up the entire correction repository fix the issue?

b-fein commented 8 months ago

Does setting up the entire correction repository fix the issue?

What does setting up the entire correction repository mean? Do I have to do something else as an instructor in the IDE before I can start the assessment of student submissions?