ls1intum / Orion

Plugin integrating Artemis programming exercises into IntelliJ
https://plugins.jetbrains.com/plugin/13217-orion--artemis-programming-exercise-integration/
MIT License
32 stars 8 forks source link

Assessment line comment strings are not html escaped #73

Closed mertcorumlu closed 3 years ago

mertcorumlu commented 3 years ago

Describe the bug

I am currently a tutor and I realized while assessing a submission that line comment strings are not being escaped while sending to artemis servers, which cause some problems such that following comments will not be sent to artemis anymore or they are interpreted as special chars such as "\n"

To Reproduce

  1. Open an assessment on Orion
  2. Add a line comment for example < Hello \n from "world" >
  3. Try adding a new line comment < test >
  4. You'll see that the first one will be sent to artemis as < Hello from> , but the second one will be ignored because of quotation marks.

Expected behavior

Strings should be html escaped before being sent to remote server

Screenshots

Screen Shot 2021-11-17 at 16 14 46 Screen Shot 2021-11-17 at 16 14 53

Environment

 - OS: MacOS
 - IntelliJ 2021.2.23
 - Browser Chrome
 - Version 96.0

Additional context

Output in IntelliJ

  [REPLACE THIS WITH YOUR INFORMATION]