search

ls1mardyn / ls1-mardyn

ls1-MarDyn is a massively parallel Molecular Dynamics (MD) code for large systems. Its main target is the simulation of thermodynamics and nanofluidics. ls1-MarDyn is designed with a focus on performance and easy extensibility.
http://www.ls1-mardyn.de
Other
28 stars 15 forks source link

Cleanup of readers #332

Open HomesGH opened 2 months ago

HomesGH commented 2 months ago

ASCII reader

The method readPhaseSpaceHeader of the ASCII reader is not used in the code anymore. Instead, the data of the config xml was already employed to set according values.

It seems that the method readPhaseSpaceHeader of the ASCII reader is just used for tests, see here.

MPI_IOCheckpointWriter and MPI_IOReader

@cniethammer @FG-TUM Do you know if the MPI_IOCheckpointWriter and MPI_IOReader classes are in use or working at all?

I couldn't find any reference and usage of those in the present code base.

On the history of the MPI_IOCheckpointWriter :

FG-TUM commented 2 months ago

After grepping the whole project, it seems MPI_IOCheckpointWriter is not used at all, and MPI_IOReader is only referenced from commented-out code once in PressureGradient, so it is also unused. Both are not registered as plugins, hence, they will probably not work at the moment.

I'd be in favor of removing them!