CMake: Include libenet.pc in installation

h3xx commented 7 months ago

Include libenet.pc in installation
Add missing project version as far as CMake is concerned; One would need to bump the version in CMakeLists.txt when releasing
~~Use GNUInstallDirs to determine install paths~~
~~Fix missing shared library symlinks~~ (Prior PR)
~~Don't default to building static libenet (Use -DBUILD_SHARED_LIBS=(ON|OFF) to control whether to build shared-only (ON) or static-only (OFF) libraries.)~~ (Prior PR)

Does not break existing ability to build using GNU Autotools. In fact, it fixes some compatibility with it (GNU Autotools installs the .pc file, therefore so should CMake).

Closes #243

Croydon commented 3 months ago

GnuInstallDirs are done via #244
Shared builds are enabled via #242

The rest might still be nice to have. Could you rebase this pull request @h3xx?

h3xx commented 3 months ago

Done rebasing. Excellent work on #242 and #244!

brad0 commented 2 months ago

This looks good to me and does what I would expect.

brad0 commented 1 month ago

@Croydon Can you please get this and the LANGUAGES CMake patch in?

Croydon commented 1 month ago

@Croydon Can you please get this and the LANGUAGES CMake patch in?

I am just another community member and can't do such a thing, sorry.

brad0 commented 3 weeks ago

I am just another community member and can't do such a thing, sorry.

Oh, my misunderstanding. I saw you in various tickets and PRs and thought maybe you were associated with the project.

lsalzman / enet

CMake: Include libenet.pc in installation #233