search

lsalzman / iqm

Inter-Quake Model format development kit
MIT License
240 stars 73 forks source link

support blender 2.67, and fix default filename #3

Closed swetland closed 10 years ago

lsalzman commented 10 years ago

The 2.63 exporter works just fine with 2.67. There is absolutely no need to copy over the file solely to change the version number which in no way prevents proper functioning in blender 2.67 or above.

The actual issues at hand were completely hidden in your pull requests by the nature of how you did things here, as the diff did NOT show what actual modifications were made, nor were the changes explained at all, thus I had to figure them out myself. In general, I always merge changes by hand, never blindly accept pull requests. In the future, EXPLAIN any changes you make.

In any case, the two underlying issues have been fixed of the typo and the filename.

swetland commented 10 years ago

Thanks for resolving the issues.

The 2.63 version did not work in 2.67 (due to the objectes typo) -- I wasn't clear if this actually was correct for .63 or not and since you seemed to have per-version directories I just threw a new one in there. Normally git diff manages to do the right thing with rename/copy + a small change, but it clearly didn't here. Sorry about confusion or annoyance caused by this. Will be sure to be more descriptive should I sent anything else your way.

I certainly don't expect anyone to blindly accept pull requests, and I have no problem with something being kicked back with a request to do it better.