search

lsapan / pgoapi-swift

A Pokemon GO API library for Swift
MIT License
97 stars 29 forks source link

Use SwiftLint? #19

Closed aust closed 7 years ago

aust commented 8 years ago

I was thinking we could use SwiftLint on this project to keep the code consistent and manageable for everyone.

westerlund commented 8 years ago

In my opinion, a Swift lint wouldn't make any difference but slow down the project. I succest writing a set of rules to follow instead.

aust commented 8 years ago

Using SwiftLint would prevent the need for everyone to come up with a list of rules. Imagine all the time spent discussing a custom rule document that people have to abide by. Running SwiftLint on each PR would be a lot faster than manually checking the rules document against the code. SwiftLint comes with some pretty good default rules and is extremely simple to set up.

lsapan commented 8 years ago

I think this makes sense. I don't have time to personally implement it, but @aust would you be able to submit a PR for it? We'll need to tweak some of the defaults due to the nature of working with protos.