search

lsapan / pgoapi-swift

A Pokemon GO API library for Swift
MIT License
97 stars 29 forks source link

Swift 3.0 conversion #50

Closed DottD closed 8 years ago

DottD commented 8 years ago

Is it possible to have a Swift 3.0 conversion of the library?

PokemonGoSucks commented 8 years ago

Most of it can be converted, but I'm not sure about the dependencies. Another issue are the protos.. I'm also not entirely familiar with Swift 3. So, help is needed.

PokemonGoSucks commented 8 years ago

Change of mind: I am working on it.

DottD commented 8 years ago

Thank you! If it can help I saw that all of the dependecies are already converted in Swift 3.0. I can also help you a bit with the conversion, but I regret I have not so much time to work on it.

sund4nce commented 8 years ago

I can also help you out. Are you available via the pogodev discord channel?

PokemonGoSucks commented 8 years ago

@mort3m I'll join the discord tonight. Here is what I've got so far: https://github.com/PokemonGoSucks/pgoapi-swift/tree/Swift3.0

I'll try to figure out the empty map response issue tonight. It may be an issue with the hashing.

PokemonGoSucks commented 8 years ago

My branch works if you set checkChallenge in setApiSettings to false. I am redoing location fixes and adding a few more things before PR.