Use real HTML links for HTML mail templates

lsascha / registeraddress

newsletter registration extension to tt_address made in Extbase + Fluid for Typo3. with double-opt in, user editing and unsubscribing

GNU General Public License v2.0

7 stars 18 forks source link

Use real HTML links for HTML mail templates #40

Closed eliashaeussler closed 5 years ago

eliashaeussler commented 6 years ago

The HTML mail templates generate URLs for the approve, edit and delete actions. These links are not wrapped with an <a> tag, therefore they're not clickable. Since the URLs are needed for the href attribute and the link output as well, I saved them into variables.

lsascha commented 6 years ago

mhh. using f:variable would definetly make it incompatible with TYPO3 Versions older than 8.6. But maybe it is time to finally drop support for older Versions.

eliashaeussler commented 6 years ago

You're right! But we could use f:alias instead which is supported in older versions as well.

lsascha commented 5 years ago

Sorry. I just got back to your pull request when i already did it a bit differently. See 7dead7f8a12d247aa4a2fa2165694b60f56d384f

Hope its ok that i will keep it and close this pull request.

But thanks anyway for opening it in the first place. 🙌