lsascha / registeraddress

newsletter registration extension to tt_address made in Extbase + Fluid for Typo3. with double-opt in, user editing and unsubscribing
GNU General Public License v2.0
7 stars 18 forks source link

[Question] Mail Conversation #50

Closed WestendVaper closed 5 years ago

WestendVaper commented 5 years ago

Hello Sascha, first thank you for this great Newsletter register extension. In the txt files with the Mail Templates like MailNewsletterRegistration.txt i put some code at top:

<f:if condition="{vorname} || {nachname}">
    <f:then>
{f:translate(key:'mail.info.greetmail')} {f:translate(key:'mail.gender.{gender}')} {vorname} {nachname},
    </f:then>
    <f:else if="{address.email}">
{f:translate(key:'mail.info.greetmail')} {address.email},
    </f:else>
    <f:else>
{f:translate(key:'mail.info.greet')},
    </f:else>
</f:if>

In the Registration, Unsubscribe and Information i get the vorname,nachname but in the success Mails not. In your Controller seems to be gender, vorname and nachname implemented for the action approve and delete. Would you please be so kind to tell me why?

best greetings from westend of germany Frank

lsascha commented 5 years ago

Hi. Good question. I guess that would be another thing that could be made a bit more standardized across all controller actions and templates.

I think you should be able to get the first name and last name using {address.firstName} and {address.lastName} in these cases.

Maybe should be changed so no one would have to guess if the name now is only inside {vorname} or only in {address.firstName}.

Will mark this as a enhancement.

lsascha commented 5 years ago

Changed that with commit 15499668fda28c603c5b07b6ecf8183695418902 Since this removes the {vorname} {nachname} variables, its a breaking change since templates have to be updated.