lsc-sde / dbt_omop_rxn_silver

Transformations, tests and snapshots for generating a clean 'silver' OMOP layer from raw 'bronze' layer.
0 stars 0 forks source link

Add complete set of tests to all sources #1

Closed vvcb closed 9 months ago

vvcb commented 9 months ago

We need all sources (which represent the bronze layer ingested from on-prem) to have a comprehensive set of tests. Let's document what these tests need to be on this issue and start picking these off in batches.

~Currently all sources are listed in ./models/sources.yml. We may want to split this into multiple files at a later stage.~

Sources are documented in multiple yaml files under ./models/omop_sources.

quindavies commented 9 months ago

Quin

Tim

quindavies commented 9 months ago

@vvcb can you comment which of the sources files you’re planning on completing so we can update the list above? Otherwise we’re going to be duplicating work we started yesterday.

vvcb commented 9 months ago

I didn't see any new changes or branches on the repo last night and didn't expect anyone to be working on this at 2am :-)

I have done a pile of work which has all been pushed to this repo on the main branch. It gives a good starting point.

Rather than write all the tests per model, it was easier , more efficient to setup the same group of tests for multiple columns across multiple sources.

quindavies commented 9 months ago

Okay so you're not going to do anymore for now so we don't need to redo the list above?

quindavies commented 9 months ago

OMOP specific tests complete Date test discussion continued on https://github.com/lsc-sde/dbt_omop_rxn_silver/issues/11