search

lschoe / mpyc

MPyC: Multiparty Computation in Python
MIT License
367 stars 76 forks source link

Improved conversion #18

Closed b-kamphorst closed 3 years ago

b-kamphorst commented 4 years ago

An earlier pull request fixed the conversion from SecFld to SecFxp/SecInt for signed secrets, but in a very inefficient way. It turns out that the fix could have been much easier and without need for a secure conversion.

codecov-commenter commented 4 years ago

Codecov Report

Merging #18 into master will decrease coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
- Coverage   90.42%   90.41%   -0.01%     
==========================================
  Files          12       12              
  Lines        3999     3996       -3     
==========================================
- Hits         3616     3613       -3     
  Misses        383      383
Impacted Files Coverage Δ
mpyc/runtime.py 86.06% <100.00%> (-0.03%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1671a7f...88c0150. Read the comment docs.

lschoe commented 3 years ago

Yes, thanks a lot! That is a nice improvement, good thinking.

Tested the change also with the demos and found no problems.