Closed MarcT0K closed 1 year ago
Patch coverage: 100.00%
and project coverage change: +0.07%
:tada:
Comparison is base (
1636d55
) 92.88% compared to head (8e61824
) 92.95%.
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Also, I've shortened the syntax for the tests to make it more like the other tests.
Looking at your commit, I've just discovered that there was some sort of aliases between np.*
and mpc.np_*
. I hadn't seen the trick in sectypes.py
to overload the functions for secure arrays. This will simplify my own codes :sweat_smile:
I'll now prepare a few other PRs to cover all numpy operations.
OK! And yes the use of np.*
calls is the intended way and can be used in most cases. Check out the demos listed in np-run-all and other unit tests to see all kinds of examples. Only in a few cases the use of mpc.np_*
calls is needed.
This PR adds unit tests to check the consistency of the integral property for various operations on secure fixed-point numbers. The current tests covers the basic arithmetic operations (additions and multiplications) and the array stacking operations (
np_vstack
,np_hstack
,np_stack
,np_column_stack
).It also fixes the inconsistency in
np_vstack
.See #67 for more details.