lschoe / mpyc

MPyC: Multiparty Computation in Python
MIT License
367 stars 76 forks source link

Fix the inconsistent integral property in np_sum #71

Closed MarcT0K closed 1 year ago

MarcT0K commented 1 year ago

This PR fixes the inconsistent integral property in np_sum. It also adds unit tests for other basic array operations: min, max, argmin, argmax, etc.

See #67 for more details.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (cd1a0a8) 92.95% compared to head (d02e9bb) 92.96%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #71 +/- ## ======================================= Coverage 92.95% 92.96% ======================================= Files 16 16 Lines 8874 8879 +5 ======================================= + Hits 8249 8254 +5 Misses 625 625 ``` | [Files Changed](https://app.codecov.io/gh/lschoe/mpyc/pull/71?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Berry+Schoenmakers) | Coverage Δ | | |---|---|---| | [mpyc/runtime.py](https://app.codecov.io/gh/lschoe/mpyc/pull/71?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Berry+Schoenmakers#diff-bXB5Yy9ydW50aW1lLnB5) | `91.54% <100.00%> (+0.01%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.

:loudspeaker: Have feedback on the report? Share it here.