search

lsd-maddrive / MobileRobotControlSystem

Bachelor's thesis, June 2018
1 stars 0 forks source link

UART module #4

Closed PonomarevDA closed 6 years ago

KaiL4eK commented 6 years ago

In function endian is used, that is not really correct. It seems like write_bytes function and for bytes-only-buffer endian is not used.

KaiL4eK commented 6 years ago

Pls, set it as bug as endian is really not used for u8 translation. After you close bug mentioned in issue - close issue itself.

PonomarevDA commented 6 years ago

Fixed. I also rewrote UART_write_string() without va_arg(), va_start() and va_end() From: https://github.com/PonomarevDA/MobileRobotControlSystem/blob/3612d45584b70736cf1becc1364dc87d094d6619/uart.c#L255-L269 To: https://github.com/PonomarevDA/MobileRobotControlSystem/blob/c9dffeec3dd2a8baae4f66a7d433c847667be3ba/uart.c#L238-L253 As a result of it: Data used: 1150 bytes (from 1596) Program used: 2970 bytes (from 6156)

KaiL4eK commented 6 years ago

Well, pretty good optimization =) One thing is question of comfortable usage as sprintf allows to use formatted output, but if we say about memory consumption - that up to you) I suppose, bug is fixed)