search

lsd-rs / lsd

The next gen ls command
Apache License 2.0
13.29k stars 431 forks source link

rollback term grid to 0.1 and release v1.1.2 #1019

Closed zwpaper closed 6 months ago

muniu-bot[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zwpaper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/lsd-rs/lsd/blob/master/OWNERS)~~ [zwpaper] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.34%. Comparing base (16181df) to head (62e93a9).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1019 +/- ## ========================================== - Coverage 84.45% 84.34% -0.11% ========================================== Files 53 53 Lines 5108 5111 +3 ========================================== - Hits 4314 4311 -3 - Misses 794 800 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

decathorpe commented 6 months ago

This is reverting part of one of my previous changes - is there a specific reason this dependency is downgraded again?

EDIT: I have now seen the referenced issue. Sorry about the regression, I didn't catch that. I agree that uutils_term_grid seems like a good / maintained alternative.