add subtitle/closed caption icons

lsd-rs / lsd

The next gen ls command

Apache License 2.0

12.8k stars 413 forks source link

add subtitle/closed caption icons #1050

Open RuralAnemone opened 1 month ago

RuralAnemone commented 1 month ago

add subtitle/closed caption icons

uses U+F015E, 󰅞 for .890, .cip, .sbv, .scc, smi, and good old .vtt

TODONE

[x] Use cargo fmt
[x] Add necessary tests (n/a)
[x] Update default config/theme in README (if applicable) (n/a)
[x] Update man page at lsd/doc/lsd.md (if applicable) (n/a)

muniu-bot[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: RuralAnemone Once this PR has been reviewed and has the lgtm label, please assign zwpaper for approval by writing /assign @zwpaper in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/lsd-rs/lsd/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

RuralAnemone commented 1 month ago

do you think 󰅞 or 󰶽 would be better? I'm honestly not sure which one fits more with the lsd theme...

RuralAnemone commented 1 month ago

this PR currently uses the first one

RuralAnemone commented 1 month ago

rerunning tests

RuralAnemone commented 1 month ago

I guess

RuralAnemone commented 1 month ago

weird idk

zwpaper commented 4 weeks ago

hi @RuralAnemone, sorry for the late reply, it's weird the CI keeps failing, I would look into it and make sure it's ok then merge the PR

RuralAnemone commented 4 weeks ago

it should be ok; I just added some more tuples to the icons array

I mean there might be a weird memory bug on windows or something but I doubt it

surely that isn't 2GB yet