lsd-rs / lsd

The next gen ls command

Apache License 2.0

12.8k stars 413 forks source link

Fixed icons alignment of various rendered width #1067

Open ehwan opened 2 weeks ago

ehwan commented 2 weeks ago

For #1054. Fixed icons to be right aligned.

Before

After

I'm not sure if it is OK to force right-align icons, but I think it is the simplest solution.

This follows the same logic as aligning 'Block::Size' or 'Block::SizeValue'.
However, for --tree, icons are aligned within same level of entries. If all entries in a directory have icons of width 1, no padding will be added even if there are icons with longer widths outside.

TODO

[x] Use cargo fmt
[x] Add necessary tests
[x] Update default config/theme in README (if applicable)
[x] Update man page at lsd/doc/lsd.md (if applicable)

muniu-bot[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ehwan Once this PR has been reviewed and has the lgtm label, please assign zwpaper for approval by writing /assign @zwpaper in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/lsd-rs/lsd/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment