Update README.md - Githubissues

tomterl commented 3 months ago

serde-0.9 no longer has this bug; testing lsd with a zero-byte colors.yaml works just fine showing the default theme.

TODO

[ ] Use cargo fmt
[ ] Add necessary tests
[ ] Update default config/theme in README (if applicable)
[ ] Update man page at lsd/doc/lsd.md (if applicable)

muniu-bot[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tomterl Once this PR has been reviewed and has the lgtm label, please assign zwpaper for approval by writing /assign @zwpaper in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/lsd-rs/lsd/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

tomterl commented 3 months ago

This is a readme only change - how important/possible are the standard todos above?

zwpaper commented 3 months ago

hi @tomterl, good catch! it's ok to ignore them for a doc update

lsd-rs / lsd

Update README.md #1069

TODO