search

lsd-rs / lsd

The next gen ls command
Apache License 2.0
13.19k stars 430 forks source link

Fix obsolete Nerd Font icons #830

Closed nix6839 closed 1 year ago

nix6839 commented 1 year ago

Replace the old code point with the new code point. See: https://github.com/ryanoasis/nerd-fonts/releases/tag/v2.3.3

Material Design Icons The Material Design Icons have to move codepoints. Historically we patch them in between F500 - FD46; but part of that range is needed for Chinese and other glyphs. With https://github.com/ryanoasis/nerd-fonts/pull/773 and Plan 5+ of https://github.com/ryanoasis/nerd-fonts/issues/365 their new home will be after F0001. And they grow considerably.

The v2.3.x release has both, the 'old' and the 'new' codepoints to enable you an easier transision. Please change already now your prompts and other uses to the new codepoints. Release v3.0.0 will finally drop the old codepoints (F500 - FD46).

TODO

codecov-commenter commented 1 year ago

Codecov Report

Merging #830 (2445d0c) into master (8c62e9e) will not change coverage. The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master     #830   +/-   ##
=======================================
  Coverage   87.35%   87.35%           
=======================================
  Files          45       45           
  Lines        4280     4280           
=======================================
  Hits         3739     3739           
  Misses        541      541
Impacted Files Coverage Δ
src/meta/name.rs 90.41% <100.00%> (ø)
src/theme/icon.rs 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

nix6839 commented 1 year ago

can you help to add some notice under FAQ about this change?

Where is the FAQ? Should I add it to the README section?

(edited) Oh sorry I found that.

nix6839 commented 1 year ago

@zwpaper I've added a FAQ. I'm not a native English speaker so please let me know if you see anything strange in the FAQs.

zwpaper commented 1 year ago

hi @nix6839, I have one more question, Are the pre-patched fonts updated to this latest v2.3.x version? https://github.com/ryanoasis/nerd-fonts#patched-fonts

looks like the Hack Nerd I was using did not show the expected icons

nix6839 commented 1 year ago

@zwpaper If you look at https://washnix.com/hack-nerd/, it is patched correctly.

image

The source code of the page: https://github.com/nix6839/hack-nerd/blob/main/index.html

zwpaper commented 1 year ago

hi @nix6839, I double check for the icons, it works like a charm, will merge after CI passed, thanks again!

nix6839 commented 1 year ago

Thank you for your hard work.