Closed juansc closed 1 year ago
It looks like I have some refactoring artifacts. I'll fix and add more documentation
Merging #843 (858e437) into master (71156b8) will increase coverage by
0.02%
. The diff coverage isn/a
.
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@ Coverage Diff @@
## master #843 +/- ##
==========================================
+ Coverage 86.52% 86.54% +0.02%
==========================================
Files 49 49
Lines 4840 4840
==========================================
+ Hits 4188 4189 +1
+ Misses 652 651 -1
Impacted Files | Coverage Δ | |
---|---|---|
src/sort.rs | 98.00% <ø> (ø) |
... and 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: juansc
The full list of commands accepted by this bot can be found here.
I think it's cleaner to break out the sorting logic into a separate crate. Once it's published I'll update this PR to use that crate instead. The code in the create has been updated and has more robust testing
hi @juansc, I have read the PR and vsort crate, and it seems great!
please add a changelog here https://github.com/lsd-rs/lsd/blob/master/CHANGELOG.md and we should be good to go.
/lgtm
New changes are detected. LGTM label has been removed.
@zwpaper Changelog has been added
thanks so much @juansc
Description
Addresses https://github.com/lsd-rs/lsd/issues/801. The root cause is that the external library that is being used does not have sufficient test coverage and is no longer maintained.
I took a look at how GNU sort is implemented and it looked simple enough to be included into this repo. I added a few test cases, including the one from the issue.
I'm still pretty new to Rust, so any code/organizational feedback is greatly appreciated
TODO
cargo fmt