search

lsd-rs / lsd

The next gen ls command
Apache License 2.0
13.16k stars 429 forks source link

[Bug]: warning message should append a newline #868

Closed zwpaper closed 1 year ago

zwpaper commented 1 year ago

Version

version

master

What OS are you seeing the problem on?

macOS

installation

cargo install

term

No response

ls-colors

No response

What happened?

using themes directory would print a Warning message, it did not append a newline char, mess up the first line of output like:

lsd
Warning: the 'themes' directory is deprecated, use 'colors.yaml' instead. a.c          Cargo.toml     color                               lsd-0.20.1     src
 b.cfg        CHANGELOG.md   doc                                 lsd-0.21.0     target

What expected?

lsd
Warning: the 'themes' directory is deprecated, use 'colors.yaml' instead.
 a.c          Cargo.toml     color                               lsd-0.20.1     src
 b.cfg        CHANGELOG.md   doc                                 lsd-0.21.0     target

What else?

should add 2 new line here
https://github.com/lsd-rs/lsd/blob/master/src/color.rs#L183
zwpaper commented 1 year ago

/good-first-issue

muniu-bot[bot] commented 1 year ago

@zwpaper: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/lsd-rs/lsd/issues/868): >/good-first-issue Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
zwpaper commented 1 year ago

/milestone v1.0.0

zwpaper commented 1 year ago

/kind bug

zwpaper commented 1 year ago

fixed by https://github.com/lsd-rs/lsd/pull/869

/close

muniu-bot[bot] commented 1 year ago

@zwpaper: Closing this issue.

In response to [this](https://github.com/lsd-rs/lsd/issues/868#issuecomment-1633494644): >fixed by https://github.com/lsd-rs/lsd/pull/869 > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.