Parse hex colors in themes (#647)

lsd-rs / lsd

The next gen ls command

Apache License 2.0

13.16k stars 429 forks source link

Parse hex colors in themes (#647) #889

Closed zappolowski closed 1 year ago

zappolowski commented 1 year ago

This fixes the issue described in #647.

crossterm recently learned to deserialize strings of the format #xxxxxx and thus we just need to delegate deserialization of colors to them.

TODO

[x] Use cargo fmt
[x] Add necessary tests
[ ] Add changelog entry
[ ] Update default config/theme in README (if applicable)
[ ] Update man page at lsd/doc/lsd.md (if applicable)

I didn't check all TODO items as I'm not sure which of these apply here.

muniu-bot[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zappolowski

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/lsd-rs/lsd/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

zwpaper commented 1 year ago

hi @zappolowski, Thanks so much for adding this feature!

/kind feature