lsd-rs / lsd

The next gen ls command
Apache License 2.0
13.16k stars 429 forks source link

Unable to disable quotes (no support for: `--quoting-style`, `QUOTING_STYLE`, or `--literal`) #894

Closed globau closed 12 months ago

globau commented 1 year ago

Version

version

lsd 1.0.0

What OS are you seeing the problem on?

macOS

installation

homebrew

term

xterm-256color

ls-colors

di=1;36:ln=35:so=32:pi=33:ex=31:bd=34;46:cd=34;43:su=30;41:sg=30;46:tw=30;42:ow=30;43

What happened?

`error: unexpected argument '--literal' found`

What expected?

`lsd` should honour `lsd --literal`, `lsd --quoting-style=literal`, and/or `QUOTING_STYLE=literal lsd`

What else?

Sadly #746 added quotes around filenames without any way to opt out.

See https://www.gnu.org/software/coreutils/quotes.html for the various options that GNU's `ls` provides.

Adding just `literal` initially would be valuable to those who are not in favour of this somewhat controversial change.
zwpaper commented 1 year ago

thanks for the advice! /kind feature /good-first-issue /help

muniu-bot[bot] commented 1 year ago

@zwpaper: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/lsd-rs/lsd/issues/894): >thanks for the advice! >/kind feature >/good-first-issue >/help Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
PanGan21 commented 1 year ago

Hi! I am not sure if someone is working on this but I did some effort implementing it in #900 Please let me know if something more is required :)