search

lsd-rs / lsd

The next gen ls command
Apache License 2.0
13.16k stars 429 forks source link

Add support for --literal flag and literal entry in config #900

Closed PanGan21 closed 12 months ago

PanGan21 commented 1 year ago

Add support for --literal in order to opt out showing filenames with quotes Closes: #894

TODO

muniu-bot[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: PanGan21

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/lsd-rs/lsd/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov-commenter commented 12 months ago

Codecov Report

Merging #900 (ff7b194) into master (93b3fb0) will decrease coverage by 0.46%. The diff coverage is 92.10%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master     #900      +/-   ##
==========================================
- Coverage   85.84%   85.38%   -0.46%     
==========================================
  Files          50       51       +1     
  Lines        4932     4996      +64     
==========================================
+ Hits         4234     4266      +32     
- Misses        698      730      +32
Files Changed Coverage Δ
src/app.rs 33.33% <ø> (ø)
src/core.rs 0.00% <0.00%> (ø)
src/meta/name.rs 87.07% <71.42%> (-0.26%) :arrow_down:
src/config_file.rs 72.72% <100.00%> (+0.27%) :arrow_up:
src/display.rs 89.84% <100.00%> (+6.61%) :arrow_up:
src/flags.rs 100.00% <100.00%> (+3.12%) :arrow_up:
src/flags/literal.rs 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

zwpaper commented 12 months ago

hi @PanGan21, can you fix the CI errors

PanGan21 commented 12 months ago

hi @PanGan21, can you fix the CI errors

I was using wrong rustc version, so I had to update Cargo.lock. Now I reverted it and used the correct rust version. Could you run the ci one more time to check if everything is fixed now?

zwpaper commented 12 months ago

thanks for the contribution! @PanGan21