search

lsd-rs / lsd

The next gen ls command
Apache License 2.0
13.16k stars 429 forks source link

RPM spec file for lsd #901

Closed daniejstriata closed 9 months ago

daniejstriata commented 1 year ago

Basic SPEC file that can be used to build a RPM for lsd.

I have precompiled packages on my fork for EL9 and AMZN AL2023. https://github.com/daniejstriata/lsd/releases

muniu-bot[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: daniejstriata

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/lsd-rs/lsd/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
zwpaper commented 11 months ago

hi @daniejstriata, thanks for the contribution, can you also add a ci to build the rpm? so that the spec file could be used and we could maintain a rpm release

daniejstriata commented 11 months ago

hi @daniejstriata, thanks for the contribution, can you also add a ci to build the rpm? so that the spec file could be used and we could maintain a rpm release

Hi @zwpaper I've not built rpms before using ci on github. I'll investigate it.

zwpaper commented 9 months ago

hi @daniejstriata, how is this PR going? maybe we could merge it first if the spec is completed.

and let the ci be another PR

daniejstriata commented 9 months ago

@zwpaper I've built lsd in copr here https://copr.fedorainfracloud.org/coprs/faramirza/lsd/ for various rpm based distros. The difference between the spec I put here and the one in my fork is that the on I'm pushing here assumes that rust and cargo is already installed whereas the other version will install the version for rust available to the distro in its repos.

I'm still unsure about the ci on github. I've never used it before. I've not yet been able to look into that. Do you know of a recommend Guide I can look at?

We could cancel this PR and redo it once more with the newer spec?

zwpaper commented 9 months ago

let's merge this one and you could always work on the CI later, for CI, please check: https://github.com/features/actions

thanks for the contribution!

daniejstriata commented 9 months ago

@zwpaper I had a look. How is the Fedora package built and should that SPEC file not be added back here rather than mine?