search

lsd-rs / lsd

The next gen ls command
Apache License 2.0
13.05k stars 425 forks source link

Improve sensitivity of last two integration tests #904

Open bbc2 opened 11 months ago

bbc2 commented 11 months ago

Those tests were only checking that the output was nonempty, so they would pretty much never detect anything fishy. We could go further but it's nontrivial because the output is nondeterministic (because of temporary files) and it's unclear if we want to build complex regexes in the test suite right now. In the meantime, here's a basic improvement.

TODO

muniu-bot[bot] commented 11 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bbc2

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/lsd-rs/lsd/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov-commenter commented 11 months ago

Codecov Report

Merging #904 (e61b419) into master (762e724) will decrease coverage by 0.82%. Report is 1 commits behind head on master. The diff coverage is 100.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master     #904      +/-   ##
==========================================
- Coverage   86.53%   85.71%   -0.82%     
==========================================
  Files          49       49              
  Lines        4848     4852       +4     
==========================================
- Hits         4195     4159      -36     
- Misses        653      693      +40
Files Changed Coverage Δ
tests/integration.rs 100.00% <100.00%> (ø)

... and 13 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more