Open sdorr0 opened 11 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: sdorr0
The full list of commands accepted by this bot can be found here.
hi @sdorr0, thanks for the contribution.
I have one more question, what is users used -h
with --size
option? this would make --size
not working?
hi @sdorr0, thanks for the contribution.
I have one more question, what is users used
-h
with--size
option? this would make--size
not working?
Hmm. Yeah, the way the code is written now, -h
will override a --size
on the command line. I see that subsequent --size
flags on the command line will override one another based on position (the 'last' one wins).
Never done Rust before. I'm not sure if there's a way to set up #[arg()]
to also incorporate a short -h
so it can play nicely with those positional dependencies, but I can research.
Would this be a requirement to merge this change in?
I may have a solution
Never mind. I've tried all kinds of approaches and can't seem to get clap to let -h
work with --size=<mode>
where the last one on the command line always wins.
So, yes, using -h
will take precedence over a supplied --size=<mode>
argument.
but it does not make sense for -h
as a general flag to overwrite the --size
as a specific flag.
many people may set the -h
as default and it may lost --size
if that
This re-enables a quick, easy to type command line flag that
ls
users are familiar with for convenience.In the event a user has changed the default configuration of
lsd
to use a size setting of something other thandefault
, this lets a user use the historically established CLI flag (-h
) to enable the human readable option without having to type--size=default
on the command line.TODO
cargo fmt