Closed domsleee closed 6 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: domsleee
The full list of commands accepted by this bot can be found here.
btw - I'm not sure why the work-in-progress
label is still on this PR.
I think muniu-bot should have removed it when I marked the PR is ready, or perhaps I missed something 😄
Could you please review this one when convenient @zwpaper
Anyway to help this forward?
sorry for the late reply, I will look into this recently
/assign /milestone v1.1.0
hi @domsleee, as it has been some time since you responded, I have pushed a commit to make this PR go forward.
hope you don't mide
Attention: 46 lines
in your changes are missing coverage. Please review.
Comparison is base (
1714d89
) 85.74% compared to head (281c74a
) 84.63%. Report is 23 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
src/meta/windows_attributes.rs | 0.00% | 18 Missing :warning: |
src/meta/mod.rs | 65.62% | 11 Missing :warning: |
src/core.rs | 0.00% | 7 Missing :warning: |
src/color.rs | 20.00% | 4 Missing :warning: |
src/meta/permissions_or_attributes.rs | 40.00% | 3 Missing :warning: |
src/flags/permission.rs | 88.88% | 1 Missing :warning: |
src/meta/filetype.rs | 80.00% | 1 Missing :warning: |
src/meta/permissions.rs | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi @zwpaper, sorry I missed your review - thanks for reviewing and helping out with this PR 🎉
Fixes: #200 by implementing #866 as the default permission setting for windows.
Context
The current default (
--permission rwx
) uses ACL on windows, which can throw errors and has performance problems, described in #200 and also in https://github.com/lsd-rs/lsd/pull/882#issuecomment-1722126112:Suggestion
--permission attributes
is introducedPrior art
eza -al
)Checklist
cargo fmt
Screenshot & comparison