lsd-rs / lsd

The next gen ls command
Apache License 2.0
13.29k stars 431 forks source link

seperator not rendering between unicode icon and executable filename #923

Open dimitrilw opened 1 year ago

dimitrilw commented 1 year ago

image

Expected behavior

Consistent use of " " separator between icons and file/directory name, in both short & long output.

Actual behavior

image image

Relevant section from ~/.config/lsd/config.yaml

# == Icons ==
icons:
  # When to use icons.
  # When "classic" is set, this is set to "never".
  # Possible values: always, auto, never
  when: auto
  # Which icon theme to use.
  # Possible values: fancy, unicode
  #theme: fancy
  # TODO: "fancy" appears to not work with my Mac; nerd font installed, so figure out why
  theme: unicode
  # Separator between icon and the name
  # Default to 1 space
  separator: " "

Note: only change made here is switch from theme: fancy to theme: unicode

zwpaper commented 1 year ago

hi @dimitrilw, thanks for reporting the issue, did you modify the icon theme?

dimitrilw commented 12 months ago

sorry slow to respond -- busy week

No mod that I'm aware of. Just changes in the config file.

zwpaper commented 12 months ago

Got it, can confirm that the unicode icon theme indeed has the problem.

it is because the executable type in unicode theme is one size and the others are two.

https://github.com/lsd-rs/lsd/blob/ae1a2cd964168dee240de1ba13dd85e08b9a26a4/src/theme/icon.rs#L101