search

lsd-rs / lsd

The next gen ls command
Apache License 2.0
13.05k stars 425 forks source link

[Bug]: Example config.yaml is not valid #931

Closed dcechano closed 10 months ago

dcechano commented 10 months ago

Version

version

lsd 0.23.1

What OS are you seeing the problem on?

Linux

installation

sudo dnf install lsd

term

No response

ls-colors

No response

What happened?

copy and pasted the example config file from the `READ_ME.md` into a config.yaml and ran `lsd --config-file ~/.config/lsd/config.yaml` and got:

`lsd: Configuration file /home/dylan/.config/lsd/config.yaml format error, unknown field `literal`, expected one of `classic`, `blocks`, `color`, `date`, `dereference`, `display`, `icons`, `ignore-globs`, `indicators`, `layout`, `recursion`, `size`, `permission`, `sorting`, `no-symlink`, `total-size`, `symlink-arrow`, `hyperlink`, `header` at line 139 column 1.

thread 'main' panicked at 'Provided file path is invalid', src/main.rs:126:33
stack backtrace:
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
`

Clearly the parse fails when it stumbles on `literal: false` but I am not sure why. Is `literal` no longer supported? If so I can submit a PR with it removed.

What expected?

I expected the file to parse.

What else?

No response

mikeharty commented 10 months ago

I caught this too, it looks like the main branch is just ahead of the latest release (release still pinned at 1.0.0, quite a bit new since then.) Probably best to build from source.

zwpaper commented 10 months ago

the master branch is meant to be the dev branch, please select the tag of your version to view the versioned docs

We have another issue tracking this to add a notice

/close

muniu-bot[bot] commented 10 months ago

@zwpaper: Closing this issue.

In response to [this](https://github.com/lsd-rs/lsd/issues/931#issuecomment-1762921301): >the master branch is meant to be the dev branch, please select the tag of your version to view the versioned docs > >We have another issue tracking this to add a notice > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.