Closed Akmadan23 closed 9 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Akmadan23
The full list of commands accepted by this bot can be found here.
Sorry @zwpaper, I noticed you have been active in merging PRs recently, could you please take a look at this? It's a very simple fix to a real problem.
hi @Akmadan23 , sorry for the late reply, I have started the test and will take a deeper look into it tomorrow, it looks good at a glance 😃
hi @Akmadan23, I have checked your fix, and it works like a charm! thanks for the contribution!
please rebase your code onto master, so that CI can pass, and then we should be good to go
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
6f8e095
) 85.76% compared to head (0231b9b
) 85.75%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Now everything should be good to go
thanks for the contribution!
The
literal
option was not correctly recognized from config file due toLiteral::from_cli
returningSome(Literal(false))
instead ofNone
, soLiteral::from_config
would never have been executed.TODO
cargo fmt