search

lsd-rs / lsd

The next gen ls command
Apache License 2.0
13.05k stars 425 forks source link

Fix `literal` flag not being recognized from config file #935

Closed Akmadan23 closed 9 months ago

Akmadan23 commented 10 months ago

The literal option was not correctly recognized from config file due to Literal::from_cli returning Some(Literal(false)) instead of None, so Literal::from_config would never have been executed.

TODO

muniu-bot[bot] commented 10 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Akmadan23

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/lsd-rs/lsd/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Akmadan23 commented 9 months ago

Sorry @zwpaper, I noticed you have been active in merging PRs recently, could you please take a look at this? It's a very simple fix to a real problem.

zwpaper commented 9 months ago

hi @Akmadan23 , sorry for the late reply, I have started the test and will take a deeper look into it tomorrow, it looks good at a glance 😃

zwpaper commented 9 months ago

hi @Akmadan23, I have checked your fix, and it works like a charm! thanks for the contribution!

please rebase your code onto master, so that CI can pass, and then we should be good to go

codecov-commenter commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6f8e095) 85.76% compared to head (0231b9b) 85.75%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #935 +/- ## ========================================== - Coverage 85.76% 85.75% -0.01% ========================================== Files 51 51 Lines 5001 4998 -3 ========================================== - Hits 4289 4286 -3 Misses 712 712 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Akmadan23 commented 9 months ago

Now everything should be good to go

zwpaper commented 9 months ago

thanks for the contribution!