lsd-rs / lsd

The next gen ls command
Apache License 2.0
12.85k stars 420 forks source link

update various dependencies #984

Closed decathorpe closed 5 months ago

decathorpe commented 5 months ago

This is a followup for https://github.com/lsd-rs/lsd/pull/938.

The term_grid update required small changes to the use of term_grid::Cell because with v0.2, it is possible to specify the alignment within the cell. Adding Alignment::Left should preserve the current behaviour.

muniu-bot[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: decathorpe

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/lsd-rs/lsd/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (73eeb7f) 84.44% compared to head (398bf0c) 85.08%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #984 +/- ## ========================================== + Coverage 84.44% 85.08% +0.63% ========================================== Files 51 51 Lines 5067 5035 -32 ========================================== + Hits 4279 4284 +5 + Misses 788 751 -37 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

zwpaper commented 5 months ago

Hi @decathorpe, thanks for the update, as you can see CI, once we upgrade the dirs dep to v5, the Windows build will fail.

can you help to fix it?

decathorpe commented 5 months ago

I briefly looked at the failure, and it seems to be a toolchain issue? I have no idea why updating Rust code should cause linker failures.

If it's dirs v5 that causes the issue, I can drop that one from the batch and we can look into the failure separately.

zwpaper commented 5 months ago

that would also be okay to leave dirs in a separate PR

decathorpe commented 5 months ago

I've dropped the dirs v4 → v5 update for now.

One thing that looks suspicious is that with v5, it now uses windows-sys instead of winapi ...

decathorpe commented 5 months ago

Strange. I dropped the dirs update, and the windows-gnu builds still failed in the same way.

decathorpe commented 5 months ago

I tried something else, maybe it changes things, maybe not. 🤞🏼

decathorpe commented 5 months ago

Looks like good ol' cargo update fixed it. Judging by the previous contents of Cargo.lock, it hadn't been done in years, so it's not surprising that it pinned some crates to versions that were missing fixes.

(After cargo update I made small adjustments to keep the MSRV at 1.70 - clap v4.5 bumped its MSRV to 1.74, so I kept it at v4.4.)

zwpaper commented 5 months ago

thanks so much for the update!

decathorpe commented 5 months ago

Great, thanks!