search

lsds / sgx-lkl

SGX-LKL Library OS for running Linux applications inside of Intel SGX enclaves
MIT License
257 stars 89 forks source link

[Tests] Reorganise tests into unit and integration tests #247

Open letmaik opened 4 years ago

letmaik commented 4 years ago

Currently, there is no clear distinction between unit and integration tests in the tests/ folder. Most tests seem to test a single feature or functionality, even though they implicitly also test more than that. Some tests are more like integration tests, e.g. the ones in languages/ or ml/. We should make the distinction more clear and add a README in the tests/ folder to say where new tests go and which tests should be created in general. This could then lead to new test suites such that integration tests only run during nightly builds, though there is clearly value in having some integration tests running for PR builds as well. Ideas welcome.

Note that this is a continuation of https://github.com/lsds/sgx-lkl/pull/235#issuecomment-628467978.

hukoyu commented 4 years ago

@davidchisnall @letmaik @prp I definitely want to work on adding scenario tests that will add value, I don't want to waste my time on useless scenarios per your explanation. Then my suggestion is please create issues for test scenarios for different languages that will add value to be implemented so that we can implement them and add to scenario tests.