lsds / sgx-lkl

SGX-LKL Library OS for running Linux applications inside of Intel SGX enclaves
MIT License
257 stars 89 forks source link

Remove unused fs creation in LTP test setup #814

Closed SeanTAllen closed 4 years ago

hukoyu commented 4 years ago

@prp @davidchisnall @letmaik , @SeanTAllen and I have question about the proper way of creating an image for test and configuration.

in https://github.com/lsds/sgx-lkl/tree/oe_port/tests/ltp/tests/batch.mk we are creating an additional image in host , and then using it in configuration https://github.com/lsds/sgx-lkl/tree/oe_port/tests/ltp/ltp_host_config.json and https://github.com/lsds/sgx-lkl/tree/oe_port/tests/ltp/ltp_tstapp_enclave_config.json

So here are my questions: 1) In current solution we create "ltp_tst_mntfs.img" (256 MB disk image to use in some LTP tests ) on host VM 2) We mount "ltp_tst_mntfs.img" to /data in https://github.com/lsds/sgx-lkl/tree/oe_port/tests/ltp/ltp_host_config.json 3) We mount /dev/vdb to /data and set LTP_DEV = /dev/vdb in https://github.com/lsds/sgx-lkl/tree/oe_port/tests/ltp//ltp_tstapp_enclave_config.json

Actually I am a bit confused and lost here and need help.

cc @jxyang @paulcallen @mikbras @bodzhang

SeanTAllen commented 4 years ago

The code that this PR removes is currently unused. I believe it was intended to be removed during a prior PR.