search

lsegal / yard

YARD is a Ruby Documentation tool. The Y stands for "Yay!"
http://yardoc.org
MIT License
1.94k stars 397 forks source link

gem install (and gem rdoc) no longer installs rdoc or ri #400

Closed joekhoobyar closed 12 years ago

joekhoobyar commented 12 years ago

After installing yard, neither gem install nor gem rdoc is able to install rdoc or ri, even when specifying --rdoc or --ri. I imagine that this is not intentional, but maybe I'm missing something.

I tracked the problem down to the fact that the overridden setup/install methods in lib/yard/rubygems/doc_manager.rb is actually more restrictive than the original rubygems version.

I've created a fix that also retains the behavior where has_yardoc? == true inhibits rdoc generation, and tested that the yri, ri, and rdoc are all being generated again by gem update/install/rdoc. I also tested that yardoc is still generated instead of rdoc when has_yardoc? == true.

Please me know what you think.

joekhoobyar commented 12 years ago

dang it, I knew that pull requests created issues, but apparently knowing is only half the battle. ;)