lsellens / OctoPrint-Cr10_leveling

Adds bed leveling buttons to the controls tab on OctoPrint
GNU Affero General Public License v3.0
10 stars 10 forks source link

The Update #34

Closed varek3d closed 2 years ago

varek3d commented 2 years ago

It's strange, I updated the OS on Octoprint. After I see the buttons to help level my bed but they no longer do anything. I get no control at all. This is very disappointing I"ve been using the plug for years and I love it. Any suggestions to repair it?

Thank you!

Sincerely,

B

Arturis commented 2 years ago

I am also experiencing this same issue, the buttons are no longer functional after updating Octoprint today to 1.7.2.

theos10 commented 2 years ago

Same probleme, see log when clic on button : 2021-11-21 19:02:30,119 - octoprint.util.comm - ERROR - Error while processing hook dashboard for phase sending and command G0 Z0F500: Traceback (most recent call last): File "/home/pi/oprint/lib/python3.7/site-packages/octoprint/util/comm.py", line 4611, in _process_command_phase tags=tags, File "/home/pi/oprint/lib/python3.7/site-packages/octoprint/util/init.py", line 1737, in wrapper return f(*args, **kwargs) File "/home/pi/oprint/lib/python3.7/site-packages/octoprint_dashboard/init.py", line 811, in process_gcode CmdDict = dict ((x,float(y)) for d,x,y in (re.split('([A-Z])', i) for i in cmd.upper().split())) File "/home/pi/oprint/lib/python3.7/site-packages/octoprint_dashboard/init.py", line 811, in CmdDict = dict ((x,float(y)) for d,x,y in (re.split('([A-Z])', i) for i in cmd.upper().split())) ValueError: too many values to unpack (expected 3)

Thank for your help

rpoland007 commented 2 years ago

I get the same issue, the buttons are there, but they don't do anything.

varek3d commented 2 years ago

Is there anything we can do other than not update?

nilshomeier commented 2 years ago

Same for me. I noticed in the terminal window it says G90, when any of the position buttons are pressed. Heat and Stop Heating also work, but the movement buttons only send a G90.

varek3d commented 2 years ago

is the developer going to help?

On Sat, Dec 4, 2021 at 5:09 PM nilshomeier @.***> wrote:

Same for me. I noticed in the terminal window it says G90, when any of the position buttons are pressed. Heat and Stop Heating also work, but the movement buttons only send a G90.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lsellens/OctoPrint-Cr10_leveling/issues/34#issuecomment-986100423, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIOKOKGKQYJMNBXEU4OKCTLUPKGRPANCNFSM5HQALDKA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--

Teacher · 3d Artist · Creator · Dreamer "...dreamers, shapers, tinkers, and makers..." Linkedin http://www.linkedin.com/in/varek3d/ » Website http://www.varek.com » Etsy Store https://www.etsy.com/shop/PixolCreation »201.754.8735

nilshomeier commented 2 years ago

Ok, I figured out, what the issue is. Basically the buttons send gcode commands to the printer. In the current release the formatting of these commands is wrong. It sends "G0 Z10F500" when it should be "G0 Z10 F500".

I fixed this in my installation, which was pretty simple actually.

ssh into your pi. navigate to the script folder: "cd oprint/lib/python3.7/site-packages/octoprint_CR10_Leveling/static" and edit the script with "sudo nano cr10leveling.js" 2021-12-05 08_19_00-pi@octopi_ ~_oprint_lib_python3 7_site-packages_octoprint_CR10_Leveling_static You should see something like this, which is the javascript code for the buttons. cr10leveling_js_fix change the code by adding the space character before the F500 and Y like in the screenshot.

Save the file and restart octoprint, then the buttons should work again. At least they did for me.

theos10 commented 2 years ago

Hi, Same probleme after change : 2021-12-05 15:12:16,987 - octoprint.util.comm - ERROR - Error while processing hook dashboard for phase sending and command G0 X40Y40F3600: Traceback (most recent call last): File "/home/pi/oprint/lib/python3.7/site-packages/octoprint/util/comm.py", line 4611, in _process_command_phase tags=tags, File "/home/pi/oprint/lib/python3.7/site-packages/octoprint/util/init.py", line 1737, in wrapper return f(*args, **kwargs) File "/home/pi/oprint/lib/python3.7/site-packages/octoprint_dashboard/init.py", line 811, in process_gcode CmdDict = dict ((x,float(y)) for d,x,y in (re.split('([A-Z])', i) for i in cmd.upper().split())) File "/home/pi/oprint/lib/python3.7/site-packages/octoprint_dashboard/init.py", line 811, in CmdDict = dict ((x,float(y)) for d,x,y in (re.split('([A-Z])', i) for i in cmd.upper().split())) ValueError: too many values to unpack (expected 3)

There is a conflict with Dashborad plugin, it work fine when i disable DashBoard plugin.

AvanOsch commented 2 years ago

I added spaces to the commands in my fork. If someone would be willing to test it out:

https://github.com/AvanOsch/OctoPrint-Cr10_leveling

(I already created a pull request)

RushHour2k5 commented 2 years ago

I added spaces to the commands in my fork. If someone would be willing to test it out:

https://github.com/AvanOsch/OctoPrint-Cr10_leveling

(I already created a pull request)

Just installed and tested, all appears well. Might want to update your readme to reference your link of 'https://github.com/AvanOsch/OctoPrint-Cr10_leveling/archive/master.zip'.

RushHour2k5 commented 2 years ago

@AvanOsch, I just wanted to come back and personally say thank you. This appears to have also fixed the responsiveness of my OctoPrint install. I kept having severe dropouts where it seemed like the interface was unresponsive and now it appears much better!

AvanOsch commented 2 years ago

@pilot76103 You're very welcome. Now let's hope @lsellens gets the main repo (and OctoPrint's update system) updated a.s.a.p.... The reason I don't have my fork updated with any info, is because I use it solely to push updates to the main branch.

lsellens commented 2 years ago

Sorry first time I'm seeing this. I'll get it updated when I get home from work tonight.

lsellens commented 2 years ago

Looks like my notifications got turned off for this repo some how. I have them on now, so I should be more responsive in the future.

AvanOsch commented 2 years ago

@lsellens Cheers!